Some convert/binding fixes #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
May 30, 2024
| @@ -1349,6 +1356,9 @@ private Expression convertExpressionImpl(JCExpression javac) { | |||
| .map(JCVariableDecl.class::cast) | |||
| .map(this::convertVariableDeclarationForLambda) | |||
| .forEach(res.parameters()::add); | |||
| int arrowIndex = this.rawText.indexOf("->", jcLambda.getStartPosition()); | |||
| int parenthesisIndex = this.rawText.indexOf(")", jcLambda.getStartPosition()); | |||
| res.setParentheses(parenthesisIndex >= 0 && parenthesisIndex < arrowIndex); | |||
There was a problem hiding this comment.
Then we most likely receive a JCErroneous instead of a JCLambda
mickaelistria
force-pushed
the
some-fixes
branch
2 times, most recently
from
e785794 to
2b3cfac
Compare
|
Fixes ~60 tests |
mickaelistria
merged commit 4d4d633
into
eclipse-jdtls:dom-with-javac
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.